Watch routes and ingress, ensure we're only using one #1169
Conversation
| route.Spec.TLS.Certificate = "" | ||
| route.Spec.TLS.Key = "" |
There was a problem hiding this comment.
I don't know if people would want to manually set certificates on routes, but this would remove them and force the use of the cluster certificates.
There was a problem hiding this comment.
Can you comment as such right on the code?
There was a problem hiding this comment.
What happens if customer provides a custom tls cert secret in the IMInstall CR? Will custom cert still work?
There was a problem hiding this comment.
What happens if customer provides a custom tls cert secret in the IMInstall CR? Will custom cert still work?
No, this would force using the certificates on the cluster.
Wouldn't they install that certificate on the cluster?
There was a problem hiding this comment.
Not sure how this works. Probably. I am ok with the fix
bdunne
force-pushed
the
watch_routes_ingress
branch
from
ea11be4
to
f3ae710
Compare
| } else { | ||
| logger.Info(fmt.Sprintf("Skipping watch for Routes! %s", err)) | ||
| } |
There was a problem hiding this comment.
Should this conditional also be on the other 2 if clauses if they fail?
There was a problem hiding this comment.
I don't think those would fail, but I added some anyway.
Allow changes to our Ingress and Route to trigger a reconcile. Routes are not available outside of OpenShift and the controller setup will fail if we try to watch resources that are not registered to the cluster. So, we first need to see if we get an error if we try to list routes. CP4AIOPS-6311
Sometimes when we are initially created we go down the ingress path rather than the routes. Then certificates are created and we switch to routes instead. Unfortunately nothing was cleaning up the ingress (and potentially associated route httpd-xxxxx if we are running in OpenShift.) This ensures that if we are using routes, we clean up any ingress that we may have created in the past. CP4AIOPS-6311
In the past we had set certificates on routes, since ManageIQ#1161 we want to use the cluster default certificates. So, if the route existed before that was merged, we need to remove the certificate and key fields. CP4AIOPS-6311
bdunne
force-pushed
the
watch_routes_ingress
branch
from
f3ae710
to
e550de3
Compare
|
Backported to |
Watch routes and ingress, ensure we're only using one (cherry picked from commit fc227fa)
CP4AIOPS-6311