Remove miq specific source #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to have only one source per Gemfile
|
Checked commit kbrock@265e07e with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
LGTM, but do you know why was it added in the first place? |
|
@Fryguy thanks for keeping me honest. I added the notes |
1 task
Thanks, I found it after you did most of the work. At the time, this repo had manageiq-gems-pending in the Gemfile:
manageiq-gems-pending included handsoap until the vmware stuff was extracted: ManageIQ/manageiq-gems-pending#169 Also, we dropped the gems pending dependency from the gemfile in this repo here: #153 |
jrafanie
approved these changes
Apr 28, 2023
Fryguy
pushed a commit
that referenced
this pull request
May 3, 2023
Remove miq specific source (cherry picked from commit bb61b83)
Fryguy
added a commit
that referenced
this pull request
Feb 7, 2024
Fixed - Fix sporadic test failure [#204] - Remove MIQ specific gem source [#209] - Double escape @ in realm to avoid shell interpretation [#211] - Move gem name loader to proper namespaced location [#208] - Separate kerberos from service principal name and use correctly [#215] - Add manageiq user to allowed_uids for sssd [#220] - Remove warning about using pg_dump [#221] - Fix specs where AwesomeSpawn private interface changed [#224] - Change the Name of the CA from something to ApplianceCA [#228] - Fix YAML.load_file failing on aliases [#234] Added - Make backward compatible changes to work with repmgr13 - version 5.2.1 [#192] - Support Ruby 3.0 [#206] - Support Ruby 3.1 [#227] - Allow rails 7 gems in gemspec [#226] Changed - Update to Highline 2.1.0 [#201] - Clean up test output (highline and stdout messages) [#210] Removed - Drop Ruby 2.7 [#223]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken CI failure
We need to have only one main source in a
Gemfilehandsoapdependency in Add rubygems.manageiq.org for handsoap dependency #109 to fix a build failure.Gemfile.lockdoes not mention any manageiq dependencies (besidesmanageiq-password) so I don't see a way we could inadvertently requirehandsoap.