Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rename feature to Duplicate #72

Merged
merged 1 commit into from
Mar 15, 2024
Merged

add rename feature to Duplicate #72

merged 1 commit into from
Mar 15, 2024

Conversation

BasilYes
Copy link
Contributor

@BasilYes BasilYes commented Feb 19, 2024

Add rename feature to Duplicate

@MakovWait
Copy link
Owner

Hey! Looks pretty good, but we already have the similar feature that is called 'Duplicate'. Any reason why we need one more similar possibility?

@BasilYes
Copy link
Contributor Author

BasilYes commented Feb 20, 2024

I think now it's very similar, so it's have not many sense now. (Be honest I did it cause I didn't know about duplicate) But when I creating it, I got some ideas in mind to upgrade it to something unique (like .tamplateignore similar to .gitignore). So I move it to draft.

@BasilYes BasilYes marked this pull request as draft February 20, 2024 06:01
@MakovWait
Copy link
Owner

I think we can apply the idea to 'Duplicate'. For instance, add a checkbox for overriding the name and add something like '.duplicate-ignore' or stuff. What do you think?

@BasilYes
Copy link
Contributor Author

I think we can apply the idea to 'Duplicate'. For instance, add a checkbox for overriding the name and add something like '.duplicate-ignore' or stuff. What do you think?

Yes, I understand. Create similar features is bad idea. I will move this functionality to Duplicate.

@BasilYes BasilYes changed the title Add ability to create new project from tempalte add rename feature to Duplicate Feb 20, 2024
@BasilYes BasilYes marked this pull request as ready for review February 20, 2024 20:33
@MakovWait MakovWait added this to the 1.2.3 milestone Feb 22, 2024
@MakovWait MakovWait merged commit 093a7ce into MakovWait:main Mar 15, 2024
@MakovWait
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants