improve compile latency #1686
Closed
improve compile latency #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SimonDanisch
commented
Feb 22, 2022
SimonDanisch
commented
- improve inferrability
- remove StaticArrays
- update precompiles
This gets away from the gensymmed functions and instead executes code to force compilation.
timholy
approved these changes
Feb 22, 2022
metrics/ttfp/benchmark-ttfp.jl
Outdated
| @@ -0,0 +1,4 @@ | |||
| t_using = @elapsed using CairoMakie | |||
| t_plot = @elapsed save("test.png", scatter(1:4)) | |||
There was a problem hiding this comment.
Suggested change
| t_plot = @elapsed save("test.png", scatter(1:4)) | |
| t_plot = (tstart = time(); save("test.png", scatter(1:4)); time() - tstart) |
For latency it's safer to use this form because @time and @elapsed will precompile the workload. (If most of it is hidden behind runtime dispatch, this isn't a big deal, but in cases with really good inference you might eliminate the latency by trying to measure it.)
metrics/ttfp/track_pr_ttfp.jl
Outdated
| Pkg.precompile("CairoMakie") | ||
|
|
||
| result_1_7 = read(`julia --project=. ./benchmark-ttfp.jl`, String) | ||
| result_th = read(`./../../../../julia_th/julia --project=. ./benchmark-ttfp.jl`, String) |
There was a problem hiding this comment.
I'm guessing most people won't have this directory on their system. (Glad you're testing it, though!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.