Make serde support optional
#6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good. Could you also bump the major version? |
|
Done Just as a heads up, I still have some more potentially breaking changes in the pipeline. I'll open an issue when I've got them all out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches
serdesupport to a non-default optional featureserdesupport is nice to have, but it is a notably heavy dependency, so I think it would be better to expose it as a non-default optional feature. This drops the number of default dependencies from 10 to 4 🎉💣 Breaking Change 💣
This change also made
SteamIDVisitorprivate. I don't think there is reason to keep it public when it is really an internal implementation detail for implementingDeserializeforSteamID, but it's possible I'm missing some niche way of using it withserde