Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Every mail is tagged by RSPAMD as RCVD_NO_TLS_LAST #1705

Closed
5 of 7 tasks
inconis opened this issue Dec 4, 2020 · 4 comments · Fixed by #2033
Closed
5 of 7 tasks

Every mail is tagged by RSPAMD as RCVD_NO_TLS_LAST #1705

inconis opened this issue Dec 4, 2020 · 4 comments · Fixed by #2033
Labels
priority/p2 Minor bug / Could have type/bug Bug. Not working as intended

Comments

@inconis
Copy link

inconis commented Dec 4, 2020

Thank you for opening an issue with Mailu. Please understand that issues are meant for bugs and enhancement-requests.
For user-support questions, reach out to us on matrix.

To be able to help you best, we need some more information.

Before you open your issue

  • Check if no issue or pull-request for this already exists.
  • Check documentation and FAQ. (Tip, use the search function on the documentation page)
  • You understand Mailu is made by volunteers in their free time — be conscise, civil and accept that delays can occur.
  • The title of the issue should be short and simple. It should contain specific terms related to the actual issue. Be specific while writing the title.

Environment & Versions

Environment

  • docker-compose
  • kubernetes
  • docker swarm

Versions

My version is 1.7

Description

Every mail received also from GMAIL is marked by RSPAMD as RCVD_NO_TLS_LAST.
Is normal because I think that mail from famous provider use TLS

Replication Steps

Simply send an email from gmail anch check RSPAMD history

Expected behaviour

I expected to recieve an email with TLS in each step.

Thanks

Thank you very much for this wonderful project that makes it possible for everyone to build a mail server
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/response_needed Waiting for a response from the author label Dec 25, 2020
@stale
Copy link

stale bot commented Jan 8, 2021

This issue has not seen activity since as it has become stale. It will now be automatically closed. Please note that this is an automatic action, and not meant in any offensive way.

@stale stale bot closed this as completed Jan 8, 2021
@nextgens nextgens reopened this Sep 16, 2021
@stale stale bot removed the status/response_needed Waiting for a response from the author label Sep 16, 2021
@nextgens nextgens added priority/p2 Minor bug / Could have type/bug Bug. Not working as intended labels Sep 16, 2021
@nextgens
Copy link
Contributor

The faulty code is at https://github.com/rspamd/rspamd/blob/0b88d35b45dcea804e47a9236a5e0244b9b70c4e/rules/misc.lua#L263 ... It should filter out LMTP

@nextgens nextgens mentioned this issue Sep 18, 2021
Closed
1 task
@nextgens nextgens mentioned this issue Oct 6, 2021
Closed
@nextgens
Copy link
Contributor

nextgens commented Oct 6, 2021

As clarified by @ghostwheel42, the problem is that nginx does the SSL termination and the PROXY protocol used in between nginx and postfix looses the information.

Options are:

@nextgens nextgens mentioned this issue Nov 1, 2021
Merged
2 tasks
bors bot added a commit that referenced this issue Nov 2, 2021
@bors @nextgens
Merge #2033
bf1bc81 
2033: Misc r=mergify[bot] a=nextgens

## What type of PR?

bug-fix

## What does this PR do?

- Remove /dkim from the rspamd container in setup as that's not necessary anymore;
`@micw` helms-chart should probably be updated too. There is an open question on whether we want to keep it on admin. We can either have DKIM keys auto-imported to the DB on upgrade (if they exist) or provide a facility to manually import them (so that the directory can be removed altogether). Having the former doesn't allow for removing /dkim from admin. `@Diman0` any opinion on what we want for 1.9?

- Remove spam points from RCVD_NO_TLS_LAST as we don't detect whether TLS was used or not.

### Related issue(s)
- close #1705

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [x] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
@bors bors bot closed this as completed in c5694cf Nov 2, 2021
nextgens added a commit to nextgens/Mailu that referenced this issue Dec 28, 2022
@nextgens
Same for front-smtp
55c1e55 
This should enable postfix to have visibility on TLS usage and fix the
following: Mailu#1705
@nextgens nextgens mentioned this issue Dec 28, 2022
Merged
2 tasks
bors bot added a commit that referenced this issue Dec 31, 2022
@bors @nextgens
Merge #2603
bba6c5b 
2603: Enable HAPROXY protocol on SUBNET r=mergify[bot] a=nextgens

## What type of PR?

bug-fix

## What does this PR do?

- Enable HAPROXY in between front and imap: With this we avoid running into the limitations of  ``mail_max_userip_connections`` and the logfiles reflect the real IP.
- Enable HAPROXY in between front and smtp: with this postfix and rspamd are aware of whether TLS was used or not on the last hop. In practice this won't work as nginx doesn't send PROTO yet.
- Discard redundant log messages from postfix

With all of this, not only are the logs easier to understand but ``doveadm who`` also works as one would expect.

### Related issue(s)
- closes #894
- #1328
- closes #1364
- #1705

## Prerequisites
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

- [ ] In case of feature or enhancement: documentation updated accordingly
- [x] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file.


Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>
nextgens added a commit to nextgens/Mailu that referenced this issue Jan 4, 2023
@nextgens
Same for front-smtp
78d8cb5 
This should enable postfix to have visibility on TLS usage and fix the
following: Mailu#1705
Diman0 pushed a commit to Diman0/Mailu that referenced this issue Jan 5, 2023
@nextgens @Diman0
Same for front-smtp
562b4ef 
This should enable postfix to have visibility on TLS usage and fix the
following: Mailu#1705
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority/p2 Minor bug / Could have type/bug Bug. Not working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Misc nextgens/Mailu
2 participants
@nextgens @inconis