fix: new default value, rename variable

MaibornWolff · Dec 22, 2023 · cf9b373 · cf9b373
1 parent d2d66eb
commit cf9b373
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/packages/frontend/src/retro/components/buttons/ImportRetroMenuItem.tsx b/packages/frontend/src/retro/components/buttons/ImportRetroMenuItem.tsx
@@ -29,7 +29,7 @@ export function ImportRetroMenuItem() {
       participants: {},
       waitingList: {},
       isVotingEnabled: false,
-      cardVotingLimit: Number.MAX_VALUE,
+      cardVotingLimit: 1,
       timerStatus: TimerStatus.STOPPED,
       timerDuration: 0,
     };

diff --git a/packages/frontend/src/retro/components/dialogs/ManageVotesDialog.tsx b/packages/frontend/src/retro/components/dialogs/ManageVotesDialog.tsx
@@ -27,7 +27,9 @@ export function ManageVotesDialog({ isOpen, close }: DialogProps) {
     handleCardVotingLimitChanged,
   } = useRetroContext();
   const [voteCount, setVoteCount] = useState(retroState.maxVoteCount);
-  const [isVotingPerCardLimited, setIsVotingPerCardLimited] = useState(true);
+  const [isMaxVotesPerCardLimited, setIsMaxVotesPerCardLimited] = useState(
+    retroState.cardVotingLimit === 1
+  );
 
   function handleCancel() {
     setVoteCount(retroState.maxVoteCount);
@@ -39,13 +41,13 @@ export function ManageVotesDialog({ isOpen, close }: DialogProps) {
   }
 
   function handleVotingLimitChange(event: ChangeEvent<HTMLInputElement>) {
-    setIsVotingPerCardLimited(event.target.checked);
+    setIsMaxVotesPerCardLimited(event.target.checked);
   }
 
   function handleStart() {
     handleChangeMaxVote(voteCount);
     handleIsVotingEnabledChanged(true);
-    handleCardVotingLimitChanged(isVotingPerCardLimited ? 1 : Number.MAX_VALUE);
+    handleCardVotingLimitChanged(isMaxVotesPerCardLimited ? 1 : Number.MAX_VALUE);
     close();
   }
 
@@ -85,7 +87,9 @@ export function ManageVotesDialog({ isOpen, close }: DialogProps) {
           Everybody has <strong>{voteCount}</strong> votes
         </Typography>
         <FormControlLabel
-          control={<Checkbox checked={isVotingPerCardLimited} onChange={handleVotingLimitChange} />}
+          control={
+            <Checkbox checked={isMaxVotesPerCardLimited} onChange={handleVotingLimitChange} />
+          }
           label="Maximum one vote per card"
         />
       </DialogContent>

diff --git a/packages/frontend/src/retro/context/RetroContext.tsx b/packages/frontend/src/retro/context/RetroContext.tsx
@@ -232,7 +232,6 @@ export function RetroContextProvider(props: RetroContextProviderProps) {
   }
 
   function handleCardVotingLimitChanged(limit: number) {
-    console.log("Voting changed to ", limit);
     dispatchAndBroadcast({ type: "CARD_VOTING_LIMIT_CHANGED", limit });
   }