Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(visualization): View encapsulation for global configuration dialog, file panel, ribbon bar #3712

Merged
merged 56 commits into from
Sep 4, 2024
Merged

chore(visualization): View encapsulation for global configuration dialog, file panel, ribbon bar #3712

merged 56 commits into from
Sep 4, 2024

Conversation

alexanderroidl
Copy link
Contributor

@alexanderroidl alexanderroidl commented Sep 4, 2024 •
edited
Loading

View encapsulation global configuration dialog and file panel

Issues: #3671, #3695

Description

Descriptive pull request text, answering:

  • Enabled view encapsulation for global configuration dialog and file panel

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@alexanderroidl alexanderroidl changed the title fix(visualization/#3671): View encapsulation global configuration dialog fix(visualization/#3671): View encapsulation for global configuration dialog and file panel Sep 4, 2024
@polina-schoenfeld-mw @alexanderroidl
feat(visualization): enable ViewEncapsulation
35c3ba7
@polina-schoenfeld-mw @alexanderroidl
refactor(visualization): improve html structure and styling
3624f01
@polina-schoenfeld-mw @alexanderroidl
feat(visualization): add own styling for the GlobalConfigurationDialo…
8b659bd 
…gComponent
@polina-schoenfeld-mw @alexanderroidl
refactor(visualization): only show space for error/hint if existing
27c6b3e
@polina-schoenfeld-mw @alexanderroidl
chore(visualization): styling improvements
baff713
@alexanderroidl
refactor(visualization): move search panel into ribbon bar module
6fa4dd7
@alexanderroidl
fix(visualization): ribbon bar menu button display
71702e0
@alexanderroidl
fix(visualization): metric chooser display
011ae94
@alexanderroidl
fix(visualization): metric chooser icons
8e81f27
@alexanderroidl
fix(visualization): metric chooser matselect dropdown
ae389cf
@alexanderroidl
fix(visualization): edge metric chooser value display
714f84e
@alexanderroidl
refactor(visualization): ribbon bar modularization
f8adfc7
@alexanderroidl
refactor(visualization): ribbon bar panels
074eec1
@alexanderroidl
fix(visualization): ribbon bar panel settings
a85346f
@alexanderroidl
fix(visualization): ribbon bar tests
182dc55
@alexanderroidl
test(visualization): ribbon bar panel tests
8c5c488
@alexanderroidl
test(visualization): ribbon bar panel tests
7919921
@polina-schoenfeld-mw @alexanderroidl
test(visualization): start tests for SearchPanelComponent
2503b8e
@alexanderroidl
test(visualization): search panel tests
967b26d
@polina-schoenfeld-mw @alexanderroidl
test(visualization): add tests for SearchPanelComponent
bcdf8e2
@polina-schoenfeld-mw @alexanderroidl
fix(visualization): show color settings in delta mode and make Ribbon…
58a0036 
…BarPanel header expandable
@polina-schoenfeld-mw @alexanderroidl
test(visualization): add tests for RibbonBarPanelComponent
3e8208d
@polina-schoenfeld-mw @alexanderroidl
test(visualization): add test for RibbonBarComponent
d0e5e9f
@alexanderroidl
fix(visualization): remove failing component inputs
c604786
@alexanderroidl
fix(visualization): fix formatting
3ebb5ef
@alexanderroidl
fix(visualization): remove deprecated test for icon color
ab58819
@alexanderroidl
fix(visualization): start fixing edgeMetricChooserComponent tests
a0fc6d8
@alexanderroidl
test(visualization): edge metric chooser
a354d4c
@polina-schoenfeld-mw @alexanderroidl
chore(visualization): formatting
491cb6b
@alexanderroidl alexanderroidl force-pushed the fix/3671/view-encapsulation-global-configuration-dialog branch from 7e7ba67 to be68441 Compare September 4, 2024 08:42
@alexanderroidl alexanderroidl enabled auto-merge (squash) September 4, 2024 08:46
@alexanderroidl alexanderroidl changed the title fix(visualization/#3671): View encapsulation for global configuration dialog and file panel chore(visualization/#3671): View encapsulation for global configuration dialog and file panel Sep 4, 2024
@alexanderroidl alexanderroidl changed the title chore(visualization/#3671): View encapsulation for global configuration dialog and file panel chore(visualization): View encapsulation for global configuration dialog and file panel Sep 4, 2024
@alexanderroidl alexanderroidl changed the title chore(visualization): View encapsulation for global configuration dialog and file panel chore(visualization): View encapsulation for global configuration dialog, file panel, ribbon bar Sep 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Visualization'

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexanderroidl alexanderroidl merged commit c98d759 into main Sep 4, 2024
7 checks passed
@alexanderroidl alexanderroidl deleted the fix/3671/view-encapsulation-global-configuration-dialog branch September 4, 2024 12:14
This was referenced Sep 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-schoenfeld-mw polina-schoenfeld-mw polina-schoenfeld-mw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderroidl @polina-schoenfeld-mw