Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix applying default scenarios #3369 #3560

Merged

Conversation

fritschldwg
Copy link
Contributor

@fritschldwg fritschldwg commented Apr 15, 2024

Fix applying default scenarios #3369

Closes: #3369

Description

  • Fixes applying default metric templates, which didn't reset options properly or caused options to break

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

@fritschldwg fritschldwg force-pushed the fix/3369/applying-metric-templates-breaks-color-options branch from d39f526 to 16b94e3 Compare April 15, 2024 07:26
Copy link
Contributor

@Nereboss Nereboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a typo to fix, otherwise LGTM!

@fritschldwg fritschldwg force-pushed the fix/3369/applying-metric-templates-breaks-color-options branch from ed52fb3 to cbfe4b9 Compare April 16, 2024 09:09
Copy link

sonarcloud bot commented Apr 16, 2024

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fritschldwg fritschldwg merged commit 45ebe96 into main Apr 16, 2024
7 checks passed
@fritschldwg fritschldwg deleted the fix/3369/applying-metric-templates-breaks-color-options branch April 16, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Applying a metric template causes color options to break
2 participants