Add search bar in custom views #3529
Conversation
fritschldwg
force-pushed
the
feature/3212/add-search-bar-in-custom-views
branch
from
7ac05f0
to
d3626ed
Compare
fritschldwg
force-pushed
the
feature/3212/add-search-bar-in-custom-views
branch
from
ce890dc
to
c07b04b
Compare
…ustom-views' into feature/3212/add-search-bar-in-custom-views # Conflicts: # visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigItemGroup/customConfigItemGroup.component.html # visualization/app/codeCharta/ui/customConfigs/customConfigList/customConfigItemGroup/customConfigItemGroup.component.ts
There was a problem hiding this comment.
One more thing that i noticed is that when the user manually opens for example the custom views in standard mode, then searches, then deletes the search term, the menu is gets closed. This might be a bit nitpicky but id prefer if we keep it open in that case (could use a boolean that tracks if the user manually opened it)
| const lowerCasedSearchTerm = searchTerm.toLocaleLowerCase().trimEnd() | ||
| return customConfigItems.filter(customConfigItem => { | ||
| const isSearchTermIncludedInName = customConfigItem.name.toLocaleLowerCase().includes(lowerCasedSearchTerm) | ||
| const isSearchTermInlcudedInMode = customConfigItem.mapSelectionMode.toLocaleLowerCase().includes(lowerCasedSearchTerm) |
There was a problem hiding this comment.
typo in isSearchTermInlcudedInMode -> it says "inlcuded"
| export class FilterCustomConfigDataBySearchTermPipe implements PipeTransform { | ||
| transform(customConfigItems: CustomConfigItem[], searchTerm: string) { | ||
| const lowerCasedSearchTerm = searchTerm.toLocaleLowerCase().trimEnd() | ||
| return customConfigItems.filter(customConfigItem => { |
There was a problem hiding this comment.
i think the filter should be its own private method here, better for readability
|
|
Add search bar in custom views
Closes: #3212
Description
Definition of Done
A PR is only ready for merge once all the following acceptance criteria are fulfilled: