Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3269/Description of Suspicious Metrics feature is missing #3285

Merged
merged 3 commits into from
May 2, 2023
Merged

Fix/3269/Description of Suspicious Metrics feature is missing #3285

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
043a09c
Move condition to hide unsuspicious metrics in the correct HTML eleme…
Hall-Ma Apr 28, 2023
2e85722
Add changelog entry
Hall-Ma Apr 28, 2023
d0ee493
Update CHANGELOG.md
Hall-Ma May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/)
### Fixed 🐞

- Show again delta of a building which have nothing in common in red or green [#3271](https://github.com/MaibornWolff/codecharta/pull/3271)
- Show always description of suspicious metrics [#3285](https://github.com/MaibornWolff/codecharta/pull/3285)
Hall-Ma marked this conversation as resolved.
Show resolved Hide resolved

### Chore 👨‍💻 👩‍💻

Expand Down
4 changes: 2 additions & 2 deletions ...ta/ui/ribbonBar/artificialIntelligence/suspiciousMetrics/suspiciousMetrics.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</button>

<mat-menu #menu="matMenu" class="ai-drop-down suspicious-metric-panel">
<div *ngIf="data.unsuspiciousMetrics.length">
<div>
<div class="title">
<div>Suspicious Metrics</div>
</div>
Expand All @@ -25,7 +25,7 @@
information can be found here:
<a href="https://maibornwolff.github.io/codecharta/docs/suspicious-metrics/">link</a> to How-To article.
</div>
<div class="title">
<div class="title" *ngIf="data.unsuspiciousMetrics.length">
{{
data.analyzedProgrammingLanguage?.length
? "Unsuspicious Metrics in " + data.analyzedProgrammingLanguage + " code"
Expand Down