Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3209 Unselecting a folder in Presentation Mode leads to console error #3215

Merged

Conversation

RomanenkoVladimir
Copy link
Member

@RomanenkoVladimir RomanenkoVladimir commented Jan 27, 2023

Fix console errors when unselecting or unhovering after selection in presentation mode; Propose a highlighting behavior change

Please read the CONTRIBUTING.md before opening a PR.

closes: #3209

Description

Fix the highlighting update leading to calculating the distance of no building when un-selecting or un-hovering after selection in presentation mode.

Furthermore I decided to change the highlighting behavior a bit, previously selecting a selected folder would lead to unhighlighting all buildings in it, same as selecting a parent folder after having selected a child one. This seemed like unintuitive behaviour, therefore I propose the following change. Tell me what you think :)

Screenshots or gifs

Old behaviour:

web-demo-highlighting.mov

Proposed change:

proposed-change.mov

@RomanenkoVladimir RomanenkoVladimir changed the title Fix console error for presentation mode, change highlighting behaviou… Fix 3209 Unselecting a folder in Presentation Mode leads to console error and propose a highlighting behavior change Jan 27, 2023
@RomanenkoVladimir RomanenkoVladimir changed the title Fix 3209 Unselecting a folder in Presentation Mode leads to console error and propose a highlighting behavior change Fix 3209 Unselecting a folder in Presentation Mode leads to console error Jan 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing and the improvements :-)

@RomanenkoVladimir RomanenkoVladimir merged commit 807cf86 into main Jan 27, 2023
@RomanenkoVladimir RomanenkoVladimir deleted the fix/3209/unselect-folder-leads-to-console-error branch January 27, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unselect a folder leads to console error
2 participants