Fix 3209 Unselecting a folder in Presentation Mode leads to console error #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanenkoVladimir
changed the title
RomanenkoVladimir
changed the title
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
ce-bo
approved these changes
Jan 27, 2023
RomanenkoVladimir
deleted the
fix/3209/unselect-folder-leads-to-console-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix console errors when unselecting or unhovering after selection in presentation mode; Propose a highlighting behavior change
Please read the CONTRIBUTING.md before opening a PR.
closes: #3209
Description
Fix the highlighting update leading to calculating the distance of no building when un-selecting or un-hovering after selection in presentation mode.
Furthermore I decided to change the highlighting behavior a bit, previously selecting a selected folder would lead to unhighlighting all buildings in it, same as selecting a parent folder after having selected a child one. This seemed like unintuitive behaviour, therefore I propose the following change. Tell me what you think :)
Screenshots or gifs
Old behaviour:
web-demo-highlighting.mov
Proposed change:
proposed-change.mov