Feature/1066/attribute descriptors for svn tokeii raw #3176
Conversation
...c/main/kotlin/de/maibornwolff/codecharta/importer/svnlogparser/converter/ProjectConverter.kt
Outdated
Show resolved
Hide resolved
...ser/src/main/kotlin/de/maibornwolff/codecharta/importer/svnlogparser/AttributeDescriptors.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/de/maibornwolff/codecharta/importer/sourcecodeparser/metrics/ProjectMetricsTest.kt
Outdated
Show resolved
Hide resolved
...er/src/main/kotlin/de/maibornwolff/codecharta/importer/tokeiimporter/AttributeDescriptors.kt
Outdated
Show resolved
Hide resolved
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
phanlezz
deleted the
feature/1066/attribute-descriptors-for-svn-tokeii-raw
branch
| @@ -160,12 +159,12 @@ class VersionControlledFileTest { | |||
| // then | |||
| assertThat(versionControlledFile.filename).isEqualTo(oldFilename) | |||
| assertThat(versionControlledFile.actualFilename).isEqualTo(filename) | |||
| assertThat(versionControlledFile.markedDeleted()).isFalse() | |||
| assertThat(versionControlledFile.markedDeleted()).isFalse | |||
There was a problem hiding this comment.
Is this not a function call anymore?
There was a problem hiding this comment.
It is an attribute provided by the assertion, afaik
| @@ -26,7 +26,7 @@ class ProjectMetricsTest { | |||
|
|
|||
| addMetricToFileInProject(projectMetrics, "foo", "mcc", 99) | |||
|
|
|||
| Assertions.assertThat(projectMetrics.projectMetrics["foo"]).isEqualToComparingFieldByField(expected) | |||
| Assertions.assertThat(projectMetrics.projectMetrics["foo"]!!.fileMetrics).isEqualTo(expected.fileMetrics) | |||
There was a problem hiding this comment.
Seems like we compare less things in these tests now? Could be change that again?
There was a problem hiding this comment.
I changed this assertion, because the field by field call is deprecated. The object only contains one attribtue, so calling it direcly for comparison is the same as the deprecated call beforehand. I could generate an equals method for this object, so the behavior would be identical as it was before.
But if another field will get added later, it is likely that the new attribute gets a dedicated test case.
Adds AttributeDescriptors to svn and tokei
RawTextParser does not need descriptors, because the imported metrics are arbitrary.
Refactored more tests to be junit5.
Updated some deprecated code. Removed some unused.
Issue: #1066