-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1066/attribute descriptors for svn tokeii raw #3176
Feature/1066/attribute descriptors for svn tokeii raw #3176
Conversation
...c/main/kotlin/de/maibornwolff/codecharta/importer/svnlogparser/converter/ProjectConverter.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work to update those dependencies! :-)
LGTM % comments and the changelog requires an update.
...ser/src/main/kotlin/de/maibornwolff/codecharta/importer/svnlogparser/AttributeDescriptors.kt
Outdated
Show resolved
Hide resolved
...st/kotlin/de/maibornwolff/codecharta/importer/sourcecodeparser/metrics/ProjectMetricsTest.kt
Outdated
Show resolved
Hide resolved
...er/src/main/kotlin/de/maibornwolff/codecharta/importer/tokeiimporter/AttributeDescriptors.kt
Outdated
Show resolved
Hide resolved
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
@@ -160,12 +159,12 @@ class VersionControlledFileTest { | |||
// then | |||
assertThat(versionControlledFile.filename).isEqualTo(oldFilename) | |||
assertThat(versionControlledFile.actualFilename).isEqualTo(filename) | |||
assertThat(versionControlledFile.markedDeleted()).isFalse() | |||
assertThat(versionControlledFile.markedDeleted()).isFalse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not a function call anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is an attribute provided by the assertion, afaik
@@ -26,7 +26,7 @@ class ProjectMetricsTest { | |||
|
|||
addMetricToFileInProject(projectMetrics, "foo", "mcc", 99) | |||
|
|||
Assertions.assertThat(projectMetrics.projectMetrics["foo"]).isEqualToComparingFieldByField(expected) | |||
Assertions.assertThat(projectMetrics.projectMetrics["foo"]!!.fileMetrics).isEqualTo(expected.fileMetrics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we compare less things in these tests now? Could be change that again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this assertion, because the field by field call is deprecated. The object only contains one attribtue, so calling it direcly for comparison is the same as the deprecated call beforehand. I could generate an equals method for this object, so the behavior would be identical as it was before.
But if another field will get added later, it is likely that the new attribute gets a dedicated test case.
Adds AttributeDescriptors to svn and tokei
RawTextParser does not need descriptors, because the imported metrics are arbitrary.
Refactored more tests to be junit5.
Updated some deprecated code. Removed some unused.
Issue: #1066