Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/1066/display tooltip description in frontend #3162

Merged
merged 53 commits into from
Dec 9, 2022
Merged

Feature/1066/display tooltip description in frontend #3162

merged 53 commits into from
Dec 9, 2022

Conversation

BenediktMehl
Copy link
Collaborator

@BenediktMehl BenediktMehl commented Dec 2, 2022 •
edited
Loading

Display Tooltip Description in Frontend

Issue: #1066

Description

Adds the new metric attributes to the legend.

  • If cc.json has attribute name: Show metric.name and metric.title of the cc.json instead of the old metric.names and metric.titles stored in metricTitles.js
  • If cc.json has metric.description: Show the metric.description in title
  • If cc.json has no attributeDescriptors: Show old metric.name and metric.title

Screenshots or gifs

image

renovate bot and others added 22 commits November 17, 2022 16:13
@renovate
chore(deps): update dependency @types/node to v18
18d5a1e
@renovate
chore(deps): update dependency @types/node to v18
4e68eb9
Migrate to nodev18
bfda176
Merge branch 'renovate/node-18.x' of github.com:MaibornWolff/codechar…
f3c4adf 
…ta into renovate/node-18.x
@BenediktMehl
Add: attributeDescriptor TEST to multiple Files (Still one compile er…
943b806 
…ror) #1066
@BenediktMehl
Add: missing reducer statement - no compile error anymore#1066
4dace64
@BenediktMehl
Refactor: rename "Size" metric in legendPanel to "Area"#1066
ca783f3 
the word "Size" is quite unusual at this position because in the code and in the ribbonbar the word "Area" is used
@BenediktMehl
Refactor: some consoleprints and delete unused variables and methods"#…
8a98721 
…1066
@BenediktMehl
Refactor: delete "test" node in attributeDescriptors layout#1066
ac1580b
@BenediktMehl
Add: entry for download feature #1066
dbcb3fa
@BenediktMehl
Refactor: move getDescription function to legendMetrics #1066
b58ddd2
@BenediktMehl
Add: implementation for merged attributeDescriptors.merger #1066
ec3d0a5
@BenediktMehl
Add: attributeDescriptor to attributeDescriptors settings #1066
8c31b19
@BenediktMehl
Add: if condition to show description in legend block for every metri…
0512829 
…c type #1066
@BenediktMehl
Refactor: methods and settings layout to fit new cc.json format #1066
c5c0c96
@BenediktMehl
Fix: test errors #1066
f56167f
@BenediktMehl
Add: title for legend blocks in legend #1066
21823bb
@BenediktMehl
Fix: remove title from color picker #1066
fde8889
@BenediktMehl
Add: case for existing title and missing description #1066
aa25ee4
@BenediktMehl
Refactor: text in legendBlock to be uniform #1066
a7d3dbe
@BenediktMehl
Merge branch 'main' into feature/1066/display-tooltip-description-in-…
cc84e0f 
…frontend
@BenediktMehl
Refactor: metricTitles cases to fit to new attribute descriptors #1066
fc4b906
@BenediktMehl
Copy link
Collaborator Author

BenediktMehl commented Dec 2, 2022 •
edited
Loading

I would suggest to refactor "metric.metricName" and "metric.title" to "metric.abbreviation" and "metric.name", because I don't think it's intuitive.
Example for current use:
"Metric.name": rloc
"Metric.title": Real Lines of Code

@BenediktMehl BenediktMehl marked this pull request as draft December 7, 2022 13:48
@BenediktMehl BenediktMehl mentioned this pull request Dec 8, 2022
Closed
18 tasks
ce-bo
ce-bo approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

BenediktMehl and others added 13 commits December 9, 2022 10:26
@BenediktMehl
TEST Refactor: change "testTimeout": 800000 #2326
0f5e5d5
@BenediktMehl
TEST Refactor: waitForFileChooser({ timeout: 800_000 #2326
8ce820e
@BenediktMehl
TEST Refactor: don't runInBand #2326
baf77cf
@friedrich-roskosch-mw
fix: downgrade puppeteer 19 -> 16 again
0b6b477
@BenediktMehl
Revert "TEST Refactor: waitForFileChooser({ timeout: 800_000 #2326"
eb3ffdc 
This reverts commit 8ce820e.
@BenediktMehl
Revert "TEST Refactor: don't runInBand #2326"
345f166 
This reverts commit baf77cf.
@BenediktMehl
Revert "TEST Refactor: change "testTimeout": 800000 #2326"
4cd007a 
This reverts commit 0f5e5d5.
@friedrich-roskosch-mw
fix: upgrade puppeteer one last time 16 -> 17
df987b6
@BenediktMehl
Merge branch 'renovate/node-18.x' into feature/1066/display-tooltip-d…
ae29ac8 
…escription-in-frontend
@BenediktMehl
Add: Test for attributeDescriptors.reducer #2326
4e03ad5
@friedrich-roskosch-mw
Merge branch 'main' into feature/1066/display-tooltip-description-in-…
188f37e 
…frontend
@BenediktMehl
Merge branch 'main' into feature/1066/display-tooltip-description-in-…
e18d987 
…frontend
@BenediktMehl
Add changelog entry #2326
44491f6
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.8% 96.8% Coverage
0.0% 0.0% Duplication

@BenediktMehl BenediktMehl merged commit 9740b92 into main Dec 9, 2022
@BenediktMehl BenediktMehl deleted the feature/1066/display-tooltip-description-in-frontend branch December 9, 2022 13:49
@BenediktMehl BenediktMehl restored the feature/1066/display-tooltip-description-in-frontend branch December 9, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenediktMehl @ce-bo @friedrich-roskosch-mw