fix: add special characters to be pronounced via latin voice #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @ilusha1991 |
|
@Mahmood-Taghavi thank you. |
|
@Mahmood-Taghavi, bumping this request. |
|
Hi @Mahmood-Taghavi |
|
Hi Roven,
From my point of view the dual voice addon works as expected and there is
no need to bring a major update.
However, please feel free to use my add-on code if you'd like to develop
any open source software!
Best wishes
Mahmood
…On Mon, Apr 8, 2024, 3:38 AM Rowen ***@***.***> wrote:
Hi @Mahmood-Taghavi <https://github.com/Mahmood-Taghavi>
Any updates?
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AELFFXNXIWPKY4DFIQHKSQTY4HNXLAVCNFSM5DEEVK62U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBUGE3DKNRWGMZQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
For this PR, will it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7 fixed the issue mentioned here for myself, and decided to contribute.
This is my first pull request, sorry if something not as it should be.
tested this solution for quite a while on my personal daily setup.