6-track-requests-from-js-library #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzone3
requested changes
Oct 3, 2023
src/types/track-request.ts
Outdated
| @@ -0,0 +1,40 @@ | |||
| export type ApiKey = string; | |||
| export type ProviderType = "openai" | "anthropic" | "langchain"; | |||
There was a problem hiding this comment.
@jzone3 the types in this file are coming straight from the pydantic models on backend. If we want to change something, we should do it on backend.
There was a problem hiding this comment.
That's not true. You can track requests with cohere for example today.
This is also a library, not the backend. There's a difference
There was a problem hiding this comment.
Got it @jzone3 will update it.
jzone3
approved these changes
Oct 4, 2023
| tags?: string[]; | ||
| request_response?: Record<string, unknown>; | ||
| prompt_input_variables?: Record<string, string> | string[]; | ||
| [k: string]: unknown; |
abubakarsohail
merged commit e4160f9
into
4-proxy-openai-requests-from-js-library
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #6