Skip to content

avoid self._errpipe_write double close #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2022
Merged

avoid self._errpipe_write double close #466

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6d0e79
avoid self._errpipe_write double close
graingert May 11, 2022
efb39bd
Merge branch 'master' into patch-1
graingert Jul 16, 2022
2f31146
Merge branch 'master' into patch-1
graingert Jul 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions uvloop/handles/process.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ cdef class UVProcess(UVHandle):
self._finish_init()

os_close(self._errpipe_write)
self._errpipe_write = -1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the write_pipe can be closed again sometimes:

uvloop/uvloop/handles/process.pyx

Lines 118 to 122 in 3e71ddc

try:
os_close(self._errpipe_write)
except OSError:
# Might be already closed
pass

if another thread allocates a file descriptor in this time then instead of raising OSError here the fd will be closed incorrectly


if preexec_fn is not None:
errpipe_data = bytearray()
Expand Down