Skip to content

Python 3.8 support #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 20, 2019
Merged

Python 3.8 support #504

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
366f072
Bump pgproto to the latest
1st1 Nov 19, 2019
13adb88
Bump Cython & uvloop deps
1st1 Nov 19, 2019
9754a45
Handle asyncio.CancelledError (now a BaseException)
1st1 Nov 19, 2019
786fbed
Stop passing `loop=` parameter (deprecated in asyncio 3.8)
1st1 Nov 19, 2019
dd91aa3
Close asyncio.Streams explicitly (do not rely on GC)
1st1 Nov 19, 2019
ad9c387
Initialize asyncio queues in Pool in an async-def context
1st1 Nov 19, 2019
ddafaa5
Pin flake8 & pycodestyle; fix style issues
1st1 Nov 19, 2019
c2cfff1
Adopt new Python 3.8 tuple.__hash__ algo for Record.__hash__
1st1 Nov 19, 2019
cc3ae9f
CI: Enable Python 3.8
1st1 Nov 19, 2019
9ee0a43
CI: Don't run uvloop tests on built wheels
1st1 Nov 19, 2019
4027794
Handle Stream.wait_closed() windows bug gracefully
1st1 Nov 19, 2019
a9b3713
Skip test_adversity on Windows & Python 3.8
1st1 Nov 20, 2019
3375fe9
Use loop.start_tls() to upgrade connections to SSL
1st1 Nov 20, 2019
5e585ef
Silence 3.8 warnings about implicit __int__ conversion
1st1 Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip test_adversity on Windows & Python 3.8 
The way the test rig is written seems to be incompatible
with ProactorEventLoop which is the dafault on Windows in
Python 3.8
  • Loading branch information
@1st1
1st1 committed Nov 20, 2019
commit a9b3713027880dc58b47f70cf43b00ccdfc80089
6 changes: 6 additions & 0 deletions tests/test_adversity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,18 @@

import asyncio
import os
import platform
import unittest
import sys

from asyncpg import _testbase as tb


@unittest.skipIf(os.environ.get('PGHOST'), 'using remote cluster for testing')
@unittest.skipIf(
platform.system() == 'Windows' and
sys.version_info >= (3, 8),
'not compatible with ProactorEventLoop which is default in Python 3.8')
class TestConnectionLoss(tb.ProxiedClusterTestCase):
@tb.with_timeout(30.0)
async def test_connection_close_timeout(self):
Expand Down