brought snippets more into alignment with language atom #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase your PR onto the recent master? |
|
Will do. Thanks. |
|
Thanks, closing this in favour of #92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this pull request to bring MagicPython's snippets back in line with the ones in Atom's language-python package.
In accordance with the advice from this closed pull request I got the additions folded into language-python first (see here).
Originally I was only going to add my "env3" and "sc" snippets but when I saw that the language-python package was ahead I went on and added import, from/import, with statement, rPDB, and PuDB.
Potential Issues
This brings the atom snippets out of alignment with the sublime snippets. I'm not good enough with sublime-snippet yet so I hope that someone else writes that up soon.