Skip to content

[compliments] fix: duplicate query param "?" in compliments module refresh url #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristjanESPERANTO merged 2 commits into from
Nov 19, 2025
Merged

[compliments] fix: duplicate query param "?" in compliments module refresh url #3967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dacb804
fix: duplicate query param "?" in compliments module refresh url
xsorifc28 Nov 18, 2025
1737086
xsorifc28 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ planned for 2026-01-01
- fixed problems with daylight-saving-time in weather provider `openmeto` (#3930, #3931)
- [newsfeed] fixed header layout issue introduced with prettier njk linting (#3946)
- [weather] fixed windy icon not showing up in pirateweather (#3957)
- [compliments] fixed duplicate query param "?" when constructing refresh url (#3967)

### Updated

Expand Down
5 changes: 3 additions & 2 deletions modules/default/compliments/compliments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,9 @@ Module.register("compliments", {
// we need to force the server to not give us the cached result
// create an extra property (ignored by the server handler) just so the url string is different
// that will never be the same, using the ms value of date
if (isRemote && this.config.remoteFileRefreshInterval !== 0) this.urlSuffix = `?dummy=${Date.now()}`;
//
if (isRemote && this.config.remoteFileRefreshInterval !== 0) {
this.urlSuffix = this.config.remoteFile.includes("?") ? `&dummy=${Date.now()}` : `?dummy=${Date.now()}`;
}
try {
const response = await fetch(url + this.urlSuffix);
return await response.text();
Expand Down