-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add CSS to clock module to prevent line breaking of sunrise/sunset information #3816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Looks good, but as there is not an open issue: Could you please provide a screenshot from before and one from after your changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the cleanup. some paddings can be done more elegantly though.
@@ -90,13 +90,25 @@ | |||
.module.clock .sun, | |||
.module.clock .moon { | |||
display: flex; | |||
white-space: nowrap; | |||
padding-top: 3px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this padding should be a gap between all child-elements of the "digital" parent. add a flex and this padding there.
} | ||
|
||
.module.clock .sun > *, | ||
.module.clock .moon > * { | ||
flex: 1; | ||
} | ||
|
||
.module.clock .fa-sun, | ||
.module.clock .fa-moon { | ||
padding-left: 3px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sun and moon classes should get this padding as a gap property too.
|
||
.module.clock .fa-arrow-up, | ||
.module.clock .fa-arrow.down { | ||
padding-left: 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, add ing the gap to the sun/moon should get rid of this padding.
I've simplified it, but I think the |
develop
branch.Done
No
Fixes #<issue_number>
?N/A
With some combinations of sunrise and sunset times (usually when the time till rise/set is >9:59), the information will break across multiple lines. This prevents that by adding CSS.
I don't consider it major.
npm run lint:prettier
before submitting so that style issues are fixed.Done
Done