[l10n] Complete translations #3794
Conversation
|
I think it's better to have the translations and take PRs for being wrong. This is such a small space of technical terms, most automated would be right. I did the same on a product years ago and only had one correction in the Korean translation |
|
go for translations |
|
I am still sceptic... Could you ask in the forums for people that can check this PR? |
KristjanESPERANTO
force-pushed
the
translations
branch
from
cd4da7b to
6d1e3b7
Compare
|
@rejas as you are active here, can you please read discord and change the permissions needed, thanks. |
To be honest, I'm not expecting any feedback, so I see it as a waste of time. We can do it and wait for reactions, but the PR should be merged before the next release. |
Since we still have some time until the next release, I think it's okay to ask the community for help: https://forum.magicmirror.builders/topic/19709/community-task-check-automated-translations 🙂 |
|
I suggest that if there is no feedback from the forum by Monday we merge this. |
|
The forums have been pretty quiet for a month now. I wouldn't expect much activity on this by Monday |
|
There is nothing to review in |
Yes, that's right. This translation was already complete, so I didn't have to touch it. |
Co-authored-by: Magnus <34011212+MagMar94@users.noreply.github.com>
KristjanESPERANTO
force-pushed
the
translations
branch
from
dd94e8d to
531e147
Compare
Short description: I completed the translations with the help of translation tools.
Long description: I'm currently looking at the translation-tests and I noticed the e2e-test
${language} should contain all base keys, (). It is supposed to check whether all keys are present in each translation file, but it doesn't actually work that way. When I fix it, a lot of missing translations are reported. I have completed these translations with the help of translation tools and packed them into this PR. I have left out the modified test so that we can focus on the question if we accept such amount of automatic translations or not.rejas has already expressed in another PR (#3775 (comment)) that he prefers human translators. I basically do too, but I don't see how we can manage to have all translations completed by humans. And even if a few translations are not correct, hopefully a user will get in touch.
If we decide against the translations, we should at least remove the test. If we go for the tranlsations, I'll add the test.
What do you think?