Added DOM_OBJECTS_UPDATED notification when the DOM is re-rendered via updateDom

[ryan-d-williams]

• Base your pull requests against the develop branch.
• Include these infos in the description:

• Does the pull request solve a related issue?
  Yes - solves Notification on subsequent DOM updates (not just the first) #3534

• If so, can you reference the issue like this Fixes #<issue_number>?
  Fixes Notification on subsequent DOM updates (not just the first) #3534 (also mentioned in commit message)

• What does the pull request accomplish? Use a list if needed.

• Adds a new notification (DOM_OBJECTS_UPDATED) when the DOM is updated via updateDom

• Please run npm run lint:prettier before submitting
• Don't forget to add an entry about your changes to the CHANGELOG.md file.

More info can be found in #3534, but as a summary:

The updateDom function is not synchronous - there is an undetermined amount of time between when it completes and when the DOM has actually been re-rendered and is ready for interaction. The existing notification (MODULE_DOM_CREATED) only fires once on the initial DOM render. This PR solves the issue of subsequent re-renders by adding a new notification that fires whenever the DOM is ready after an update. This notification falls within expected lifecycle notifications (very similar to other libraries that provide DOM lifecycle notifications).

[ryan-d-williams]

Failed tests seem to be a result of #3532 (PR #3533) and not caused by the PR

[khassel]

Failed tests seem to be a result of #3532 (PR #3533) and not caused by the PR

yes ...

[ryan-d-williams]

@khassel sorry I should've phrased my question better:

Do I need to update my PR to have the same changes as #3533 so the tests pass, or can my PR still be accepted with failing tests given they are fixed in #3533?

[khassel]

or can my PR still be accepted with failing tests

in this case, yes.

[khassel]

@ryan-d-williams the test fix is ​​merged, best approach would be to rebase/merge your PR on new develop, thanks!

[ryan-d-williams]

@khassel is it possible to have an admin restart the tests? If develop was updated a restart should show the tests pass?

I'm happy to do a rebase/merge, but that's going to take me a minute of fumbling around and probably destroying my branch at least a few times so if we can take the path of least resistance of restarting the tests I would appreciate it. If that's not possible I'll try to get the branch updated.

[khassel]

is it possible to have an admin restart the tests?

yes, but they will run on the same commit and fail again

if it is o.k. for you I can do the rebase

[ryan-d-williams]

@khassel that would be great thank you! If you don't mind letting me know the steps you took - it's been a while since I've done a rebase like this so it would be nice to refresh my memory on it for next time.

[khassel]

If you don't mind letting me know the steps you took

well, I'm using a graphical tool called "Git Extensions" under Windows, steps:

• add your repo as remote and fetch it
• checkout your branch #3534
• rebase this branch on develop by selecting the target commit
• force-push the updated branch #3534 (which is only possible for maintainers of the project or you as owner)

[ryan-d-williams]

@khassel thank you! I made it to the end, but when I saw I had to force-push I figured I had messed something up.

Thanks again!

[sdetweil]

i think it should be fixed now in dev.. he just put in in current release.. don't need extra debt..

[khassel]

so I will fix it on develop ...

[khassel]

done.

[ryan-d-williams]

My fault, sorry about that. Thanks for the fix @khassel

[khassel]

No problem, it's not the first time and I hate the current construction with the changelog ...