Conversation
The sunset icon was never displayed because the if statement was different. The sunset and sunrise were are in HH:MM and now in another timestamp. _sunset > now should be _sunset > _now
Collaborator
|
Cool, Thanks! |
Contributor
Author
|
Graag gedaan,
Ik ben zelf met een versie bezig met de volgende veranderingen:
1) Windrichting voor de dag wordt weergegeven.
2) Windrichting en snelheid voor de vooruitzichten.
3) Temperatuur icon naast de temperaturen bij de vooruitzichten
4) Pijl naast de huidige temp of deze omhoog gaat of omlaag.
Als je wil kan ik ze doorvoeren.
Gr Erik
From: Michael Teeuw
Sent: Sunday, November 1, 2015 6:45 PM
To: MichMich/MagicMirror
Cc: LithiumNL
Subject: Re: [MagicMirror] Update weather.js (#32)
Cool, Thanks!
—
Reply to this email directly or view it on GitHub.
|
Broutard
pushed a commit
to Broutard/MagicMirror
that referenced
this pull request
Jan 9, 2016
Update weather.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sunset icon was never displayed because the if statement was different. The sunset and sunrise were are in HH:MM and now in another timestamp.
_sunset > now should be _sunset > _now