Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling to node_helper startup sequence #2945

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Oct 13, 2022

Fixes #2944

Also splits the Server js into a constrcutor and an open call to remove one callback parameter :-)

@rejas rejas changed the base branch from master to develop October 13, 2022 21:16
@codecov-commenter
Copy link

Codecov Report

Merging #2945 (86cba45) into develop (7bbf8c1) will decrease coverage by 0.52%.
The diff coverage is 58.33%.

@@             Coverage Diff             @@
##           develop    #2945      +/-   ##
===========================================
- Coverage    64.06%   63.54%   -0.53%     
===========================================
  Files            9        9              
  Lines          295      299       +4     
===========================================
+ Hits           189      190       +1     
- Misses         106      109       +3     
Impacted Files Coverage Δ
js/server.js 66.21% <56.89%> (ø)
js/app.js 59.20% <64.28%> (-1.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rejas rejas marked this pull request as ready for review October 14, 2022 13:40
js/app.js Show resolved Hide resolved
js/server.js Show resolved Hide resolved
@rejas rejas merged commit 64ed5a5 into MagicMirrorOrg:develop Oct 19, 2022
@rejas rejas deleted the issue_2944 branch October 19, 2022 19:40
@khassel
Copy link
Collaborator

khassel commented Oct 19, 2022

"never merge your own PR" ...

@rejas
Copy link
Collaborator Author

rejas commented Oct 19, 2022

wups :-(

@rejas
Copy link
Collaborator Author

rejas commented Oct 19, 2022

will be more patient with my weather refactor branch, I promise!

@khassel
Copy link
Collaborator

khassel commented Oct 19, 2022

tell me if you want to wait for more approvals there or if I should merge ...

@rejas
Copy link
Collaborator Author

rejas commented Oct 19, 2022

Since that (#2849) is quite large, the more eyes the better (looking at @sdetweil @MichMich and maybe @buxxi too for reviews of it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node_helper errors during startup prevent other module helpers from starting
4 participants