Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use internal fetch function of node #2855

Merged
merged 3 commits into from
May 28, 2022
Merged

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented May 27, 2022

related to #2649

With Node >= v18 comes an internal fetch method. This PR centralizes the use of fetch in a new module js/fetch.js and uses the internal fetch function of node instead external node-fetch library if node version >= v18.

@codecov-commenter
Copy link

Codecov Report

Merging #2855 (ab7934f) into develop (a4c77f0) will decrease coverage by 0.98%.
The diff coverage is 28.57%.

@@             Coverage Diff             @@
##           develop    #2855      +/-   ##
===========================================
- Coverage    64.80%   63.82%   -0.99%     
===========================================
  Files            8        9       +1     
  Lines          287      293       +6     
===========================================
+ Hits           186      187       +1     
- Misses         101      106       +5     
Impacted Files Coverage Δ
js/fetch.js 16.66% <16.66%> (ø)
js/server.js 66.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c77f0...ab7934f. Read the comment docs.

@MichMich MichMich merged commit 4f1db74 into MagicMirrorOrg:develop May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants