Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom-properties to css for improved styling #2537

Merged
merged 31 commits into from
Apr 15, 2021

Conversation

rejas
Copy link
Collaborator

@rejas rejas commented Apr 14, 2021

Fixes issue #2513, supersedes #2515, all credits to @earlman

@earlman
Copy link
Contributor

earlman commented Apr 14, 2021

🙏

@MichMich MichMich merged commit 54c98b4 into MagicMirrorOrg:develop Apr 15, 2021
@rejas rejas deleted the custom-properties branch April 15, 2021 14:23
// Uncomment and adjust accordingly if you want to import another font from the google-fonts-api:
// @import url('https://fonts.googleapis.com/css2?family=Poppins:wght@100;300;400;700&display=swap');

// Change color and fonts here:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// This is js comment not css
/* This is css comment */

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info, will update the sample

@rejas rejas mentioned this pull request Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants