use relative path for socket.io

[Legion2]

This Pull Request fix #1934

• It changes the javascript include path of the /socket.io/socket.io.js to a relative one, like all the other scripts
• It appends the path of the current window to the path of the socket.io endpoint

[Legion2]

@MichMich should I rebase the PR?

[khassel]

@MichMich can we get this merged before the new release next week? Or why are you hesitating?

[MichMich]

Merged.

[RoadRunnr1469]

I don't understand what you mean by "Remove additional slash from path" below I'm tasing my socket client.js

var MMSocket = function(moduleName) {
var self = this;

    if (typeof moduleName !== "string") {
            throw new Error("Please set the module name for the MMSocket.");
    }

    self.moduleName = moduleName;

    // Private Methods
    self.socket = io("/" + self.moduleName, {
            path: window.location.pathname + "socket.io"
    });
    var notificationCallback = function() {};

    var onevent = self.socket.onevent;
    self.socket.onevent = function(packet) {
            var args = packet.data || [];
            onevent.call(this, packet); // original call
            packet.data = ["*"].concat(args);
            onevent.call(this, packet); // additional call to catch-all
    };

    // register catch all.
    self.socket.on("*", function(notification, payload) {
            if (notification !== "*") {
                    notificationCallback(notification, payload);
            }
    });

    // Public Methods
    this.setNotificationCallback = function(callback) {
            notificationCallback = callback;
    };

    this.sendNotification = function(notification, payload) {
            if (typeof payload === "undefined") {
                    payload = {};
            }
            self.socket.emit(notification, payload);
    };

};

[Legion2]

@MichMich @RoadRunnr1469 I created a PR #1976 which reverts the path to its old default, but it can be changed in the config.