fix run-start.sh: if running in docker-container, just start electron…#1861
fix run-start.sh: if running in docker-container, just start electron…#1861MichMich merged 1 commit intoMagicMirrorOrg:developfrom khassel:develop
Conversation
|
@sdetweil What are your thoughts on this PR? |
|
I would have captured the result of the grep and added it to the other decision tree choices, and launched electron at the end like it does, rather than add another launch my old training is don't duplicate |
thought about this solution first, but decided against. So the first And this fix is only needed until #1860 is implemented. But if it is consensus here i can change it. |
|
I'll merge it for now, but chances are that the script is removed in the next version. Thanks for your contribution. |
Fixes #1859
With this fix the
run-start.shscript differentiate if running in a docker-container or not: