Error handling for bad git data in updatenotification#1507
Merged
MichMich merged 2 commits intoMagicMirrorOrg:developfrom Jan 4, 2019
Merged
Error handling for bad git data in updatenotification#1507MichMich merged 2 commits intoMagicMirrorOrg:developfrom
MichMich merged 2 commits intoMagicMirrorOrg:developfrom
Conversation
shbatm
added a commit
to shbatm/MagicMirror
that referenced
this pull request
Jan 4, 2019
MichMich
added a commit
that referenced
this pull request
Jan 5, 2019
Fixes Incomplete fix for #1507
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updatenotification module did not ignore errors in the simple-git git.log() call. After some module updates on my installation I started seeing frequent UnhandledPromiseRejectionWarning errors:
This PR aborts the call if
data2.latestis undefined for some reason. It is a nuisance error and the only negative side effect should be that we don't know if a module has an update; however, this is the same handling as if the fetch() call failed.Related to closed issues #1164 and #1285.