Skip to content

[Bug] electron test are failing for new electron version v39 #3933

@khassel

Description

@khassel
run electron-rebuild:
⠹ Building module: node-libgpiod, Completed: 0
make: Entering directory '/root/node_modules/node-libgpiod/build'
  CXX(target) Release/obj.target/node-libgpiod/src/main.o
In file included from /root/.electron-gyp/39.0.0/include/node/v8-handle-base.h:8,
                 from /root/.electron-gyp/39.0.0/include/node/v8-local-handle.h:13,
                 from /root/.electron-gyp/39.0.0/include/node/v8-array-buffer.h:12,
                 from /root/.electron-gyp/39.0.0/include/node/v8.h:24,
                 from /root/.electron-gyp/39.0.0/include/node/node.h:80,
                 from ../../nan/nan.h:62,
                 from ../src/bulk.hh:5,
                 from ../src/main.cc:1:
/root/.electron-gyp/39.0.0/include/node/v8-internal.h:440:1: warning: multi-line comment [-Wcomment]
  440 | //         / \
      | ^
/root/.electron-gyp/39.0.0/include/node/v8-internal.h:442:1: warning: multi-line comment [-Wcomment]
  442 | //       / \
      | ^
In file included from ../../nan/nan.h:302:
../../nan/nan_maybe_43_inl.h: In function 'Nan::Maybe<bool> Nan::SetPrototype(v8::Local<v8::Object>, v8::Local<v8::Value>)':
../../nan/nan_maybe_43_inl.h:210:15: error: 'class v8::Object' has no member named 'SetPrototype'; did you mean 'GetPrototype'?
  210 |   return obj->SetPrototype(isolate->GetCurrentContext(), prototype);
      |               ^~~~~~~~~~~~
      |               GetPrototype
../../nan/nan.h: In constructor 'Nan::Utf8String::Utf8String(v8::Local<v8::Value>)':
../../nan/nan.h:1173:36: warning: 'int v8::String::WriteUtf8(v8::Isolate*, char*, int, int*, int) const' is deprecated: Use WriteUtf8V2 instead. [-Wdeprecated-declarations]
 1173 |         length_ = string->WriteUtf8(v8::Isolate::GetCurrent(), str_,
      |                   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1174 |                                     static_cast<int>(len), 0, flags);
      |                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /root/.electron-gyp/39.0.0/include/node/v8-object.h:14,
                 from /root/.electron-gyp/39.0.0/include/node/v8-array-buffer.h:14:
/root/.electron-gyp/39.0.0/include/node/v8-primitive.h:212:7: note: declared here
  212 |   int WriteUtf8(Isolate* isolate, char* buffer, int length = -1,
      |       ^~~~~~~~~
../../nan/nan.h: At global scope:
../../nan/nan.h:2645:38: warning: 'v8::DEFAULT' is deprecated: not used [-Wdeprecated-declarations]
 2645 |   , v8::AccessControl settings = v8::DEFAULT
      |                                      ^~~~~~~
/root/.electron-gyp/39.0.0/include/node/v8-object.h:188:7: note: declared here
  188 |       DEFAULT V8_ENUM_DEPRECATED("not used") = 0,
      |       ^~~~~~~
../../nan/nan.h:2646:47: warning: 'AccessControl' is deprecated: This enum is no longer used and will be removed in V8 14.3. [-Wdeprecated-declarations]
 2646 |   , v8::PropertyAttribute attribute = v8::None) {
      |                                               ^
/root/.electron-gyp/39.0.0/include/node/v8-object.h:187:5: note: declared here
  187 |     AccessControl {
      |     ^~~~~~~~~~~~~
../../nan/nan.h:2696:38: warning: 'v8::DEFAULT' is deprecated: not used [-Wdeprecated-declarations]
 2696 |   , v8::AccessControl settings = v8::DEFAULT
      |                                      ^~~~~~~
/root/.electron-gyp/39.0.0/include/node/v8-object.h:188:7: note: declared here
  188 |       DEFAULT V8_ENUM_DEPRECATED("not used") = 0,
      |       ^~~~~~~
../../nan/nan.h:2697:47: warning: 'AccessControl' is deprecated: This enum is no longer used and will be removed in V8 14.3. [-Wdeprecated-declarations]
 2697 |   , v8::PropertyAttribute attribute = v8::None) {
      |                                               ^
/root/.electron-gyp/39.0.0/include/node/v8-object.h:187:5: note: declared here
  187 |     AccessControl {
      |     ^~~~~~~~~~~~~
/root/.electron-gyp/39.0.0/include/node/node.h:1251:7: warning: cast between incompatible function types from 'void (*)(Nan::ADDON_REGISTER_FUNCTION_ARGS_TYPE)' {aka 'void (*)(v8::Local<v8::Object>)'} to 'node::addon_register_func' {aka 'void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, void*)'} [-Wcast-function-type]
 1251 |       (node::addon_register_func) (regfunc),                          \
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/.electron-gyp/39.0.0/include/node/node.h:1285:3: note: in expansion of macro 'NODE_MODULE_X'
 1285 |   NODE_MODULE_X(modname, regfunc, NULL, 0)  // NOLINT (readability/null_usage)
      |   ^~~~~~~~~~~~~
../src/main.cc:131:1: note: in expansion of macro 'NODE_MODULE'
  131 | NODE_MODULE(NativeExtension, InitAll);
      | ^~~~~~~~~~~
make: *** [node-libgpiod.target.mk:132: Release/obj.target/node-libgpiod/src/main.o] Error 1
make: Leaving directory '/root/node_modules/node-libgpiod/build'
Error: `make` failed with exit code: 2
    at ChildProcess.<anonymous> (/root/node_modules/node-gyp/lib/build.js:219:23)

✖ Rebuild Failed

An unhandled error occurred inside electron-rebuild
node-gyp failed to rebuild '/root/node_modules/node-libgpiod'

Error: node-gyp failed to rebuild '/root/node_modules/node-libgpiod'
    at ChildProcess.<anonymous> (file:///root/node_modules/@electron/rebuild/lib/module-type/node-gyp/node-gyp.js:114:24)
    at ChildProcess.emit (node:events:508:28)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12)

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency filenot ours

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions