v2.24.0 won´t start in clientonly-Mode

[PatteWi]

Hi all,

i have running MagicMirror in a VM on a NUC in server-mode (headless) and access to it with an RPI3 behind a screen/Mirror in clientonly-mode. After i updated Server and Client to v2.24.0, the client isn´t able to connect to the server again. It doesn´t even start.
As a workaround i downgraded the client to v2.23.0 and i can access again.

The pm2-Error-Log shows the following:

[15989:0714/150618.971749:ERROR:viz_main_impl.cc(186)] Exiting GPU process due to errors during initialization
/home/pi/MagicMirror/node_modules/electron/dist/electron exited with signal SIGINT
[16153:0714/150641.691336:ERROR:viz_main_impl.cc(186)] Exiting GPU process due to errors during initialization
[16162:0714/150642.888062:ERROR:command_buffer_proxy_impl.cc(128)] ContextResult::kTransientFailure: Failed to send GpuControl.CreateCommandBuffer.

BR
Patrick

[sdetweil]

yep, a bug..

we changed startup for asynchronous modules, .. but removed a part that is needed for client only..

temp fix if u want

in clientonly/index.js
add

				const env = Object.create(process.env);
				env.clientonly=true;     // <---------add this line
				const options = { env: env };

in js/electron.,js add

/**
 * Handle errors from self-signed certificates
 */
app.on("certificate-error", (event, webContents, url, error, certificate, callback) => {
	event.preventDefault();
	callback(true);
});

if(process.env.clientonly){                                    //  add these 6 lines...  between the sections above and below
	app.whenReady().then(() => {
		Log.log("Launching application.");
		createWindow();
	});
}

// Start the core application if server is run on localhost
// This starts all node helpers and starts the webserver.

[khassel]

@sdetweil could reproduce this and your fix works, so can you please provide a PR for this? Thanks.

[sdetweil]

done