Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMHI isn't working with the weather module #2955

Closed
el97 opened this issue Oct 20, 2022 · 10 comments · Fixed by #2956
Closed

SMHI isn't working with the weather module #2955

el97 opened this issue Oct 20, 2022 · 10 comments · Fixed by #2956
Assignees

Comments

@el97
Copy link
Contributor

el97 commented Oct 20, 2022

I found a bug in MagicMirror

Please make sure to only submit reproducible issues. You can safely remove everything above the dividing line.
When submitting a new issue, please supply the following information:

Platform: Raspberry Pi 4 4GB

Node Version: 17.8.0

MagicMirror² Version: 2.21.0

Description: I am unable to use SMHI in the weather integration. The module just get stuck in "loading" and nothing happens. I tried to use Openweathermap as a provider and that worked without any issues.

Steps to Reproduce: Use SMHI as a weather provider.

Expected Results: Current weather when I use SMHI.

Actual Results: The module get stuck at loading

Configuration: config.txt

@rejas
Copy link
Collaborator

rejas commented Oct 21, 2022

Thanks for your report. Seems like the smhi api doesnt like lat lon coordinates with more than 6 digits (after the point). So please try these config values:

			lat: 59.322665,
			lon: 18.069666,

And report back please :-)

@el97
Copy link
Contributor Author

el97 commented Oct 21, 2022

Thank you for the reply. It didn't make any change sadly.

@rejas
Copy link
Collaborator

rejas commented Oct 22, 2022

Strange. Can you please post your updated config entry for the weather module? Also: can you post any errors from the console?

@el97
Copy link
Contributor Author

el97 commented Oct 22, 2022

Here is my config for the weather module. The only related output to the weather module from the console is No helper found for module: weather.

			module: "weather",
			header: "Väder",
			position: "top_right",
				config: {
					weatherProvider: "SMHI",
					lat: 56.166473,
					lon: 15.229300,
					precipitationValue: 'pmedian',
					type: "current",
						},
		},

@rejas
Copy link
Collaborator

rejas commented Oct 23, 2022

That config entry works for me.
The output you mention is fron the server part and is fine.
Can you also get the output from the brwoser part (start MM in server mode and brwose with your brwoser to it)?

@rejas
Copy link
Collaborator

rejas commented Oct 23, 2022

Or even easier: Start the MM with 'npm run start:dev' then the browser console appears on the right and you can see error messages etc pp

@el97
Copy link
Contributor Author

el97 commented Oct 23, 2022

I managed to find this in the console.

smhi.js:36 Could not load data: this.calculateAT is not a function
(anonymous) @ smhi.js:36
Promise.catch (async)
fetchCurrentWeather @ smhi.js:36
(anonymous) @ weather.js:177

@rejas
Copy link
Collaborator

rejas commented Oct 23, 2022

Ah, yes that got fixed recently with #2931

Three possibilites for you:
a) check out the develop branch (if you are familiar with git)
b) wait till 1.1.2023 when the new version with the fix is release
c) manually change the code

@sdetweil
Copy link
Collaborator

@el97
Copy link
Contributor Author

el97 commented Oct 23, 2022

I fixed it! Thanks for the help @rejas

@el97 el97 closed this as completed Oct 23, 2022
rejas pushed a commit to rejas/MagicMirror that referenced this issue Oct 24, 2022
khassel pushed a commit that referenced this issue Oct 24, 2022
…ates (#2956)

Fixes #2955

Co-authored-by: veeck <michael@veeck.de>
MichMich added a commit that referenced this issue Jan 1, 2023
## [2.22.0] - 2023-01-01

Thanks to: @angeldeejay, @buxxi, @dariom, @dWoolridge,
@KristjanESPERANTO, @MagMar94, @naveensrinivasan, @retroflex, @SkySails
and @tom.

Special thanks to @khassel, @rejas and @sdetweil for taking over most
(if not all) of the work on this release as project collaborators. This
version would not be there without their effort. Thank you!

### Added

- Added test for remoteFile option in compliments module
- Added hourlyWeather functionality to Weather.gov weather provider
- Removed weatherEndpoint definition from weathergov.js (not used)
- Added css class names "today" and "tomorrow" for default calendar
- Added Collaboration.md
- Added new github action for dependency review (#2862)
- Added a WeatherProvider for Open-Meteo
- Added Yr as a weather provider
- Added config options "ignoreXOriginHeader" and
"ignoreContentSecurityPolicy"

### Removed

- Removed usage of internal fetch function of node until it is more
stable

### Updated

- Cleaned up test directory (#2937) and jest config (#2959)
- Wait for all modules to start before declaring the system ready
(#2487)
- Updated e2e tests (moved `done()` in helper functions) and use es6
syntax in all tests
- Updated da translation
- Rework weather module
- Make sure smhi provider api only gets a maximum of 6 digits
coordinates (#2955)
  - Use fetch instead of XMLHttpRequest in weatherprovider (#2935)
  - Reworked how weatherproviders handle units (#2849)
  - Use unix() method for parsing times, fix suntimes on the way (#2950)
  - Refactor conversion functions into utils class (#2958)
- The `cors`-method in `server.js` now supports sending and recieving
HTTP headers
- Replace `&hellip;` by `…`
- Cleanup compliments module
- Updated dependencies including electron to v22 (#2903)

### Fixed

- Correctly show apparent temperature in SMHI weather provider
- Ensure updatenotification module isn't shown when local is _ahead_ of
remote
- Handle node_helper errors during startup (#2944)
- Possibility to change FontAwesome class in calendar, so icons like
`fab fa-facebook-square` works.
- Fix cors problems with newsfeed articles (as far as possible), allow
disabling cors per feed with option `useCorsProxy: false` (#2840)
- Tests not waiting for the application to start and stop before
starting the next test
- Fix electron tests failing sometimes in github workflow
- Fixed gap in clock module when displayed on the left side with
displayType=digital
- Fixed playwright issue by upgrading to v1.29.1 (#2969)

Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
Co-authored-by: Karsten Hassel <hassel@gmx.de>
Co-authored-by: Malte Hallström <46646495+SkySails@users.noreply.github.com>
Co-authored-by: Veeck <github@veeck.de>
Co-authored-by: veeck <michael@veeck.de>
Co-authored-by: dWoolridge <dwoolridge@charter.net>
Co-authored-by: Johan <jojjepersson@yahoo.se>
Co-authored-by: Dario Mratovich <dario_mratovich@hotmail.com>
Co-authored-by: Dario Mratovich <dario.mratovich@outlook.com>
Co-authored-by: Magnus <34011212+MagMar94@users.noreply.github.com>
Co-authored-by: Naveen <172697+naveensrinivasan@users.noreply.github.com>
Co-authored-by: buxxi <buxxi@omfilm.net>
Co-authored-by: Thomas Hirschberger <47733292+Tom-Hirschberger@users.noreply.github.com>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: Andrés Vanegas Jiménez <142350+angeldeejay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants