Skip to content

Commit

Permalink
fix electron start loadurl on windows when address="0.0.0.0" (#3268)
Browse files Browse the repository at this point in the history
> - Does the pull request solve a **related** issue?
Fixes #2550 

> - What does the pull request accomplish? Use a list if needed.

changes the loadUrl to use localhost, as electron and MM are on this
same system
the mm 'server' is still listening on all adapters, including localhost
  • Loading branch information
sdetweil authored Nov 15, 2023
1 parent 70ddd80 commit 247115d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ _This release is scheduled to be released on 2024-01-01._
- Fix issue template (#3167)
- Fix #3256 filter out bad results from rrule.between
- Fix calendar events sometimes not respecting deleted events (#3250)
- Fix electron loadurl locally on Windows when address "0.0.0.0" (#2550)

## [2.25.0] - 2023-10-01

Expand Down
2 changes: 1 addition & 1 deletion js/electron.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function createWindow() {
prefix = "http://";
}

let address = (config.address === void 0) | (config.address === "") ? (config.address = "localhost") : config.address;
let address = (config.address === void 0) | (config.address === "") | (config.address === "0.0.0.0") ? (config.address = "localhost") : config.address;
mainWindow.loadURL(`${prefix}${address}:${config.port}`);

// Open the DevTools if run with "npm start dev"
Expand Down

0 comments on commit 247115d

Please sign in to comment.