Skip to content

fix type checking for dataset init and increment version #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewilyas merged 3 commits into from
Jul 11, 2020
Merged

fix type checking for dataset init and increment version #59

andrewilyas merged 3 commits into from
Jul 11, 2020

Conversation

@andrewilyas
Copy link
Collaborator

@andrewilyas andrewilyas commented Jul 10, 2020

  • Previously, initializing a dataset with custom class directly didn't work, because of the type checking put in during the last version. This is fixed by not type checking if there is no default argument.
  • Removed a misleading comment
  • Increment the version so that robustness.__version__ returns the right thing.

@Hadisalman Hadisalman self-requested a review July 10, 2020 04:36
Hadisalman
Hadisalman reviewed Jul 10, 2020
View reviewed changes
@andrewilyas andrewilyas merged commit 375d9ef into master Jul 11, 2020
@Hadisalman Hadisalman deleted the custom_class_and_version branch July 12, 2020 09:00
tomerashkenazy pushed a commit to brainsandmachines/robustness that referenced this pull request Aug 19, 2025
@andrewilyas
Merge pull request MadryLab#59 from MadryLab/custom_class_and_version
2749a0f 
fix type checking for dataset init and increment version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hadisalman Hadisalman Hadisalman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewilyas @Hadisalman