Repository navigation
Bump IBM Notifier to 3.2.4 (fixes user auth failing when login files print output) - #415
Open
alex-straw-avantia wants to merge 1 commit into
Open
alex-straw-avantia wants to merge 1 commit into
alex-straw-avantia wants to merge 1 commit into
Conversation
IBM Notifier 3.2.3 launches its UI helper via `su -l`, so anything the console user's login files print ends up in the dialog output. super reads that output as the password, so user authentication fails even with the correct password. 3.2.4 launches the helper with `launchctl asuser` instead, with no login shell. Raising the minimum version makes existing 3.2.3 installs fail check_ibm_notifier and get re-downloaded.
Owner
|
Thanks for this! I probably won't merge directly from this because there are other changes I want to incorporate in the next build of v5. That being said I will happily credit your changes in the changelog and release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: IBM Notifier 3.2.3 launches its UI helper via
su -l, so anything the console user's login files print (.zprofileetc.) gets mixed into the dialog output. super reads that output as the password, so the user authentication dialog rejects a correct password every time. IBM Notifier 3.2.4 launches the helper withlaunchctl asuserinstead (no login shell), which fixes it.Background
When super runs as root, IBM Notifier 3.2.3 starts the popup helper as the console user with
su -l <user> -c '<helper path>' <payload>(TaskManager.swiftin v-3.2.3-b-135).su -lruns a login shell, so.zprofile/.zlogin/.profileget sourced, and anything they print lands in the helper's stdout. IBM Notifier returns that stdout as the dialog response, and super then runsdscl /Local/Default -authonly "${current_user_account_name}" "${dialog_response}". The user sees "User authentication failed." no matter what they type.It also shows up in the unified log as
IBM Notifier: TERM environment variable not set.when a login file runsclear.IBM fixed this in 3.2.4 (IBM/mac-ibm-notifications@a0ed60e) - the helper is now started with
launchctl asuser <uid> <helper> <payload>, no shell involved.What changed
IBM_NOTIFIER_DOWNLOAD_URLto the v-3.2.4-b-136 release.IBM_NOTIFIER_MINIMUM_VERSIONto 3.2.4 so existing 3.2.3 installs failcheck_ibm_notifier, get removed and re-downloaded.super.checksum.txtfor the new script hash.Testing
All on Apple silicon, macOS 26.6, running IBM Notifier as root with the same secure input dialog super builds for the AUTH dialog (same accessory +
-position center -always_on_top -disable_quit), then checking the response with super'sdscl -authonlycall.Repro + fix - with a one-line
~/.zlogin(echo "NOISE: simulated chatty login file"), real 19 char password pasted into each dialog:dscl -authonlyon full response (what super does)Same dialog run as the user (not root) on 3.2.3 returns 19 chars and is accepted, so it's only the root ->
su -lpath. Also confirms paste still works in the 3.2.4 helper now that it's launched vialaunchctl asuser.Install / upgrade - ran super's own
get_ibm_notifier+check_ibm_notifieragainst a scratch folder:3.2.4 is notarized with the same Team ID (PETKK2G752).
bash -n superclean.Notes
CHANGELOG.mdalone so you can word it however you like.if [[ -o interactive && -t 1 ]]; then ... fiin.zprofile.🤖 Generated with Claude Code