Messenger & WorldManager Rework #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Update of both Messenger, reworking it as an expandable codec registry for chat types and World Manager.
What is the current behavior? (You can also link to an open issue here)
Messenger can't register new chat types and the chat type class is not extendable, and not part of the API. World manager still uses the old manager design.
What is the new behavior? (If this is a feature change)
Messenger can register new chat types implemented by the user, World Manager uses a new manager design without atomic references.
Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No.