-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trying to enhance graph products #2576
base: development
Are you sure you want to change the base?
Conversation
trying to fix Macaulay2#2262
oops
Well, this seems to (sometimes) trigger a failure in Chordal Graphs. |
The failure is here: G = cartesianProduct(cycleGraph 3, pathGraph 5)
I = edgeIdeal G
N = chordalNet(toLex I)
assert(treewidth elimTree N == 6) Could it be that treewidth depends on the order the vertices of a graph are listed in? (We get 10 instead of 6.) |
This in turn is using
|
Well, that looks independent of the order of vertices. Hmm. |
It seems to me that the result could depend on the ordering of the vertices of the graph. So it could be normal that the tree-width is changed. Indeed the doctest just below finds another tree-width. Maybe one should ask the authors of the package if it is ok to change the doctest ? |
The definition of treewidth at https://en.wikipedia.org/wiki/Chordal_graph makes it clear that the ordering of the vertices is not relevant. |
Hmm. Trying inside sagemathcell (so M2 version 1.18) to change the labels in the example, I got
and this gives 10. |
Can we conclude that there's a bug somewhere in one of those packages? |
Either there is a bug, or we do not understand something in the math. I do not claim to understand if treewidth depends on the order of vertices or not. Shall we ask the package authors ? |
Yes, let's. @jburkar1 , @dcookii , @carolinejansen , @abokeefe ? |
ping @jburkar1 , @dcookii , @carolinejansen , @abokeefe We need your help in understanding a failing doctest, please. |
Maybe we should try emailing them directly. |
Actually, "treewidth" is in the package "Chordal", whose authors are different. |
Okay, I've sent email to the authors of Graphs and of Chordal. |
Frédéric, if we could demonstrate that there is a bug in |
Still not clear to me what goes wrong. Here is another tentative
which gives three different results. |
Here is a smaller example, where we can see explicitly that both edge ideals are isomorphic
|
in the previous simplified example, the elim trees look really different. |
Here is an even more simplified case
|
Very strangely, the failure depends on the value of the third vertex in C1 ; it fails for 22 and 12, works for -6, 10 and 11 and fails differently for -1.. |
Why do we see no test results? |
Do you mean "please show us the results" ?
giving a periodicity 8 :
where I have erased the special cases 0 and 1 that conflict with other vertices |
This strange behaviour depends on the label in the second factor graph:
giving
|
so that they allow more general labels, as required by #2262