Skip to content
This repository was archived by the owner on May 3, 2023. It is now read-only.

RLS v0.24.2 #43

Merged
merged 7 commits into from
Mar 14, 2019
Merged

RLS v0.24.2 #43

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
958e8ea
RLS v0.24.2
jorisvandenbossche Mar 12, 2019
c7ec5c6
deselect failing tests
TomAugspurger Mar 13, 2019
09fd4f4
fix deselect
TomAugspurger Mar 13, 2019
8dce6dc
remove pytest pin
TomAugspurger Mar 13, 2019
fdaf246
Revert "remove pytest pin"
TomAugspurger Mar 13, 2019
fa04e18
alternate skip
TomAugspurger Mar 13, 2019
3423895
ignore test exit code
TomAugspurger Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
alternate skip
  • Loading branch information
@TomAugspurger
TomAugspurger committed Mar 13, 2019
commit fa04e18d94c02ae69e22466e54f90019315a8354
2 changes: 1 addition & 1 deletion config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ function run_tests {
python -c 'import pandas; pandas.show_versions()'
# --deselect for 0.24.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we could write a patch and apply it before running the tests. I'm not sure which is preferred. I'm also not sure if the patch would affect the pandas version number picked up by versioner (IIRC that's set at this point, but I may be wrong).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really prefer not to change this at all. these need to be fixed in pandas 0.24.x branch and then just re-run this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more patches need to be backported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that require a new tag?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly, we should do the backports like pandas-dev/pandas#25186 anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can overwrite the tag if need be as it hasn't been released

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote to just skip the tests here, as Tom is doing. It has already been released on github. Making a new tag / release is easy, but not sure it is worth it for skipping a test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what???? why was this put on github before this??? that is crazy

# https://travis-ci.org/MacPython/pandas-wheels/builds/505474702
python -c 'import pandas; pandas.test(extra_args=["--skip-slow", "--skip-network", "--skip-db", "-n=2", "--deselect=pandas/tests/indexes/multi/test_analytics.py::test_numpy_ufuncs", "--deselect=pandas/tests/io/test_common.py::TestCommonIOCapabilities::test_write_fspath_all"])'
python -c 'import pandas; pandas.test(extra_args=["--skip-slow", "--skip-network", "--skip-db", "-n=2", "-k -test_numpy_ufuncs", "-k -test_write_fspath_all"])'
}