[MEDIUM] Hardcoded Configuration Values Should Be Configurable

[MacJediWizard]

Description

Several configuration values are hardcoded throughout the codebase instead of being configurable via config file or environment variables.

Locations

HTTP Client settings

`internal/client/client.go` lines 27-29

client.SetTimeout(30 * time.Second)  // Hardcoded timeout
client.SetRetryCount(3)              // Hardcoded retry count
client.SetRetryWaitTime(2 * time.Second)  // Hardcoded retry wait

Docker socket path

`internal/integrations/docker/docker.go` line 20

dockerSocketPath = "/var/run/docker.sock"  // Should support custom paths

WebSocket settings

`cmd/patchmon-agent/commands/serve.go` lines 310-318, 374, 382-384

// Hardcoded backoff values
time.Sleep(1 * time.Second)  // Initial backoff
// Max backoff 30 seconds
// Ping interval 30 seconds
// Read deadline 90 seconds

Recommended Fix

1. Add configuration options to `config.yml`:

http:
  timeout: 30s
  retry_count: 3
  retry_wait: 2s

docker:
  socket_path: /var/run/docker.sock

websocket:
  initial_backoff: 1s
  max_backoff: 30s
  ping_interval: 30s
  read_deadline: 90s

2. Load values from config with sensible defaults:

timeout := cfg.HTTP.Timeout
if timeout == 0 {
    timeout = 30 * time.Second  // Default
}
client.SetTimeout(timeout)

Severity

🟡 MEDIUM - Operational flexibility

Labels

enhancement, medium, code-quality

[MacJediWizard]

Deferred: This enhancement requires significant refactoring to properly implement.

Analysis:
The current hardcoded values work well for most deployments. Making these configurable would require:

1. Extending the config struct with new fields
2. Adding validation for each configurable value
3. Updating documentation
4. Maintaining backward compatibility

Current hardcoded values that work for most use cases:

• HTTP timeout: 30s (appropriate for most networks)
• Retry count: 3 (standard retry pattern)
• Retry wait: 2s (reasonable backoff)
• Docker socket: /var/run/docker.sock (standard path)
• WebSocket ping: 30s (standard keepalive)

Recommendation:
Create a separate issue/PR for this enhancement with:

1. Detailed design for the configuration schema
2. Migration path for existing installations
3. Documentation updates

For now, these values are reasonable defaults that work in production environments. Users with special requirements can fork and modify.

Priority: This is a LOW priority enhancement as the current defaults work for the vast majority of deployments.