added diversity parameter to update_topics() function #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Nice catch, that should definitely be changed! Could you remove the additional whitespace after the diversity parameter and docstrings? Other than that it looks good to me. |
Contributor
Author
|
done! |
Owner
|
Thanks for the quick update! LGTM, I'll go ahead and merge this now 😄 |
Contributor
Author
|
Sorry, I missed out on another parameter - I think top_n_words should also be added, right? I'm creating another pull request. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diversity parameter is a component of topic representation; rather than topic formation (docs -> embeddings -> dimensionality_reduction -> clustering). The update_topics() function should provide the functionality to change the diversity parameter, as and when required. Thanks!