Skip to content

Commit

Permalink
Fix schema change core dump because of null stats (apache#2049)
Browse files Browse the repository at this point in the history
  • Loading branch information
kangpinghuang authored and imay committed Oct 23, 2019
1 parent d33e169 commit e3c39a1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions be/src/olap/schema_change.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1312,6 +1312,7 @@ OLAPStatus SchemaChangeHandler::_do_process_alter_tablet_v2(const TAlterTabletRe
_reader_context.return_columns = &return_columns;
// for schema change, seek_columns is the same to return_columns
_reader_context.seek_columns = &return_columns;
_reader_context.stats = &_stats;

for (auto& rs_reader : rs_readers) {
rs_reader->init(&_reader_context);
Expand Down Expand Up @@ -1428,6 +1429,7 @@ OLAPStatus SchemaChangeHandler::schema_version_convert(
_reader_context.delete_handler = &delete_handler;
_reader_context.return_columns = &return_columns;
_reader_context.seek_columns = &return_columns;
_reader_context.stats = &_stats;

RowsetReaderSharedPtr rowset_reader;
RETURN_NOT_OK((*base_rowset)->create_reader(&rowset_reader));
Expand Down
2 changes: 2 additions & 0 deletions be/src/olap/schema_change.h
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,8 @@ class SchemaChangeHandler {
private:
RowsetReaderContext _reader_context;

OlapReaderStatistics _stats;

DISALLOW_COPY_AND_ASSIGN(SchemaChangeHandler);
};

Expand Down

0 comments on commit e3c39a1

Please sign in to comment.