Skip to content

Commit

Permalink
[chore](join) delete code that's useless (apache#37016)
Browse files Browse the repository at this point in the history
  • Loading branch information
jacktengg authored Jul 4, 2024
1 parent dbe1078 commit 10697d0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
9 changes: 0 additions & 9 deletions be/src/pipeline/exec/hashjoin_probe_operator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -160,14 +160,6 @@ bool HashJoinProbeLocalState::_need_probe_null_map(vectorized::Block& block,
return false;
}

void HashJoinProbeLocalState::init_for_probe(RuntimeState* state) {
if (_probe_inited) {
return;
}

_probe_inited = true;
}

void HashJoinProbeLocalState::add_tuple_is_null_column(vectorized::Block* block) {
DCHECK(_parent->cast<HashJoinProbeOperatorX>()._is_outer_join);
if (!_parent->cast<HashJoinProbeOperatorX>()._use_specific_projections) {
Expand Down Expand Up @@ -235,7 +227,6 @@ HashJoinProbeOperatorX::HashJoinProbeOperatorX(ObjectPool* pool, const TPlanNode
Status HashJoinProbeOperatorX::pull(doris::RuntimeState* state, vectorized::Block* output_block,
bool* eos) const {
auto& local_state = get_local_state(state);
local_state.init_for_probe(state);
SCOPED_TIMER(local_state._probe_timer);
if (local_state._shared_state->short_circuit_for_probe) {
// If we use a short-circuit strategy, should return empty block directly.
Expand Down
2 changes: 0 additions & 2 deletions be/src/pipeline/exec/hashjoin_probe_operator.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ class HashJoinProbeLocalState final

void prepare_for_next();
void add_tuple_is_null_column(vectorized::Block* block) override;
void init_for_probe(RuntimeState* state);
Status filter_data_and_build_output(RuntimeState* state, vectorized::Block* output_block,
bool* eos, vectorized::Block* temp_block,
bool check_rows_count = true);
Expand Down Expand Up @@ -92,7 +91,6 @@ class HashJoinProbeLocalState final
uint32_t _build_index = 0;
bool _ready_probe = false;
bool _probe_eos = false;
std::atomic<bool> _probe_inited = false;
int _last_probe_match;

// For mark join, last probe index of null mark
Expand Down

0 comments on commit 10697d0

Please sign in to comment.