var scope variables to make component thread safe #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the super slow response, @clarkie. I just somehow missed the notification for your pull request. I'll take a look in the morning. Thanks! |
|
Just took a look. I ran into a couple minor problems with CF8 complaining if vars aren't declared at the top of functions but it's not a big issue. I'm going to merge your pull request and then will fix the problems causing CF8 to squawk. Thanks for contributing! |
MWers
added a commit
that referenced
this pull request
Oct 24, 2014
var scope variables to make component thread safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found we were getting errors like Element at position [1] doesn't exist in array and after a bit of debugging I found that var scoping the arrays fixed the issue.
Tested on Railo 4.1.2.005