Feature: Enable Bud bundle support / Fix EnqueueStyles & EnqueueScripts #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MWDelaney, could you please accept this pull request? I have tested this and I am using it in my project as a composer patch but would like to remove the patch as I can not use the patch package on my production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Sage theme comes with Bud by default now, instead of Laravel Mix. Bud uses bundle names to enqueue assets and not paths like before. I made the adjustments so that we can now use the Bud bundles as a value of EnqueueStyles and EnqueueScripts. It would look like this:
If the bundle is not found, it will still try to enqueue a path to file in public like before.
I made sure not to break backwards compatibility, so Sage <10 users and Laravel Mix users on older versions will not get in trouble with this update.