fix: expanding factions array by reference#481
Merged
LordMidas merged 2 commits intoDec 17, 2025
Conversation
TaroEld
approved these changes
Dec 17, 2025
array.resize with passing an array just adds that same array by reference to all the new slots. We instead need to push a new array to each slot.
LordMidas
force-pushed
the
fix-factions-array-expansion-happening-by-reference
branch
from
e562418 to
a2c78fc
Compare
TaroEld
approved these changes
Dec 17, 2025
LordMidas
deleted the
fix-factions-array-expansion-happening-by-reference
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array.resize with passing an array just adds that same array by reference to all the new slots. We instead need to push a new array to each slot.