fix: trying to reset fields on potentially unadded skills from weapon#480
Merged
LordMidas merged 2 commits intoDec 13, 2025
Merged
Conversation
Non-stacking skills are not added to a skill_container that already has a skill with that ID. So if a weapon tries to add such a skill, it will not get added to the container. Therefore, we add a guard statement and return early in this case.
TaroEld
reviewed
Dec 13, 2025
TaroEld
left a comment
TaroEld
left a comment
Member
There was a problem hiding this comment.
Should the same not be done for the equivalent shield hook?
TaroEld
approved these changes
Dec 13, 2025
LordMidas
deleted the
fix-add-check-for-skill-added-before-resetting-fields
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-stacking skills are not added to a skill_container that already has a skill with that ID. So if a weapon tries to add such a skill, it will not get added to the container. Therefore, we add a guard statement and return early in this case.