fix: allow null in writeString of serde emulator#443
Merged
Conversation
When serializing a SerializationData, outside a regular save process of the game, the MetaData contains things such as Name, Filename etc. which are null but are stored in the SerializationEmulator with `writeString`. This does NOT throw any errors if the SerializationData is serialized during a regular game save cycle using the native `_out` object instead of a SerializationEmulator. However, with the emulator it throws an exception due to this requirement. In order to match the behavior of the vanilla native object, we should allow nulls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When serializing a SerializationData, outside a regular save process of the game, the MetaData contains things such as Name, Filename etc. which are null but are stored in the SerializationEmulator with
writeString. This does NOT throw any errors if the SerializationData is serialized during a regular game save cycle using the native_outobject instead of a SerializationEmulator. However, with the emulator it throws an exception due to this requirement. In order to match the behavior of the vanilla native object, we should allow nulls.This PR is on top of the other PR which fixes exceptions in the write integer cases: #412.