feat: add unique id to entity that is serialized#430
Merged
Conversation
Member
|
Don't entities already have IDs? |
Member
Author
They are not persistent and are changed upon every game load. |
Darxo
approved these changes
Feb 6, 2025
So it automatically gets ser/deserialized during entity ser/de and is properly set during deser instead of after it - because flags are the first thing to get deserialized.
- Entities without UID not getting assigned one after loading MSU in existing campaign. - Explicitly give the UID a null value during deserialization of the game.
LordMidas
force-pushed
the
feat-unique-id-for-entities
branch
from
906c117 to
61a1fb5
Compare
TaroEld
reviewed
Mar 10, 2025
TaroEld
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vanilla has a
getID()for entities but that ID is changed on every game load. This PR adds a Unique ID to every entity that is preserved across game save/load. This can be useful for a number of things.