Fix serialization metadata becoming invalid#396
Merged
LordMidas merged 3 commits intoJul 16, 2024
Conversation
Enduriel
approved these changes
Jul 15, 2024
Enduriel
left a comment
Enduriel
left a comment
Member
There was a problem hiding this comment.
Actually ultimately quite a clean solution even if the doubled onBeforeSerialize scares me a bit, I feel like this might be able to cause issues but all the scenarios I could come up with are covered, a more 'correct' approach would be to use a wrapper around the real metadata during onBeforeSerialize which duplicates everything into an emulator, but that might not be worth the work as this is quite clean
TaroEld
approved these changes
Jul 16, 2024
LordMidas
force-pushed
the
fix-serialization-metadata-becoming-invalid
branch
from
437d65f to
06b55b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.